iden3 / go-iden3-crypto

Go implementation of some cryptographic primitives (that fit inside the SNARK field) and compatible with circomlib
Apache License 2.0
117 stars 38 forks source link

Add scanner/valuer interface to signature #27

Closed arnaubennassar closed 4 years ago

arnaucube commented 4 years ago

I'm not sure to add dependencies to a particular sql library in a library about elliptic curve primitives. Maybe this tries to solve specific needs for a specific separated project?

Update: sqlite from the tests have been removed

ed255 commented 4 years ago

Looks good to me! I believe we will also need to implement Scanner & Valuer for babyjub.PublicKey, maybe you can do it in this PR as well?