search

iden3 / snarkjs

zkSNARK implementation in JavaScript & WASM
GNU General Public License v3.0
1.79k stars 424 forks source link

chore: add 'options' parameter to 'groth16FullProve', and pass it through to 'wtns_calculate' #519

Closed ichub closed 2 months ago

artwyman commented 2 months ago

For future-proofing, it might be a good idea to add these options to the other proving systems which call wtns_calculate (i.e. plonk_full_prove and fflonk_full_prove). We don't use those in Zupass currently, but might want to try them someday.

OBrezhniev commented 2 months ago

Hi @ichub, please rename options to wtnsCalcOptions (just in case we would need prover options in the future) and add it to plonk & fflonk full prove, as @artwyman suggested.

ichub commented 2 months ago

Thanks @artwyman and @OBrezhniev - I've made the requested changes.

OBrezhniev commented 2 months ago

There's missing wtnsCalcOptions in fflonkFullProve. I'll add it in my branch.