search

identifiers-org / identifiers-org.github.io

MIT License
8 stars 1 forks source link

Colon in prefix `mmmp:biomaps` causes issues parsing CURIEs #165

Closed cthoyt closed 1 year ago

cthoyt commented 3 years ago

The algorithm to parse a CURIE is typically to string split on the leftmost colon (or specified delimiter) and therefore prefixes should not contain any of the characters that are typically used as delimiters (e.g., colon :, right slash /, underscore _).

An alternative algorithm is to dynamically compile a regular expression for what a CURIE "is" that enumerates all of the prefixes w.r.t. a given registry, but this just doesn't feel right.

I'd request that this prefix is renamed to mmmp.biomaps as the dot . character has been used as a safe delimiter in several other instances (e.g., pubchem.compound).

hHermjakob commented 3 years ago

Although it's a change in namespace, which normally should be avoided, I don't see an alternative here, as it's clearly not functional as is. TBD.

cthoyt commented 2 years ago

Any updates?

renatocjn commented 1 year ago

I will be closing this since the biomaps is not available anymore anyway.

cthoyt commented 1 year ago

As https://registry.identifiers.org/registry/mmmp:biomaps has not been removed from the Identifiers.org service, I don't think that it's appropriate to close this issue without addressing it

renatocjn commented 1 year ago

I mean the repository http://www.mmmp.org/MMMP/public/biomap/listBiomap.mmmp where resolutions were directed to. In the future, the namespace will be turned into a tombstone record as the data is not available anymore. The specifics of the implementation of tombstones in idorg are still under discussion.