identifiers-org / identifiers-org.github.io

MIT License
8 stars 1 forks source link

Bug in regexp-matching ensembl_peptide_id_version #201

Closed jonovik closed 2 years ago

jonovik commented 2 years ago

The ensembl identifier ENSOMYP00000000018.1 can be looked up as
https://www.ensembl.org/id/ENSOMYP00000000018.1
and should match the regexp given at https://identifiers.org/ensembl as shown in this regex101 example.

However, visiting https://identifiers.org/ensembl/ENSOMYP00000000018.1 currently complains:

INVALID resolution request for 'ensembl/ENSOMYP00000000018.1', due to 'Resolution request 'ensembl/ENSOMYP00000000018.1' is NOT ABOUT A NAMESPACE; For namespace 'ensembl', provided local ID 'ENSOMYP00000000018.1' DOES NOT MATCH local IDs definition pattern '^((ENS[FPTG]\d{11}(\.\d+)?)|(FB\w{2}\d{7})|(Y[A-Z]{2}\d{3}a-zA-Z?)|([A-Z_a-z0-9]+(\.)?(t)?(\d+)?([a-z])?))$''

Given that the regexp does match when I try this at regex101.com, it seem that the intention is for ensembl_peptide_id_version to be accepted just like the corresponding ensembl_peptide_id currently is.


Examples of what works and what does not work:

This ensembl_peptide_id works fine:
https://identifiers.org/ensembl/ENSOMYP00000000018
redirects to the same page as https://www.ensembl.org/id/ENSOMYP00000000018

This ensembl_peptide_id_version is not accepted:
https://identifiers.org/ensembl/ENSOMYP00000000018.1
should redirect to the same page as https://www.ensembl.org/id/ENSOMYP00000000018.1
but gives the error message quoted above.

(I could not find any canonical reference for the terms ensembl_peptide_id and ensembl_peptide_id_version, but they can be seen in this BioMart tutorial.)

cthoyt commented 2 years ago

See also https://github.com/identifiers-org/identifiers-org.github.io/issues/193, other people have had ensembl issues in the last 6 months but there haven't been any replies from the Identifiers.org team. In general, it appears they have been struggling to address any community feedback in the last few years.

In the mean time, this issue has already been solved by the Bioregistry (https://bioregistry.io, https://github.com/biopragmatics/bioregistry) a project with the goal to make curation of a global registry for the life sciences more community oriented and sustainable.

The ensembl page on the Bioregistry: https://bioregistry.io/ensembl, and the following two CURIEs are resolve without issue

jonovik commented 2 years ago

Thanks. Sorry about my newbie failure to search for previous issues. I'll close this one.