search

ideoforms / signalflow

A sound synthesis framework for Python, designed for clear and concise expression of complex musical ideas
https://signalflow.dev
MIT License
167 stars 14 forks source link

Windows compatibility #83

Closed timmb closed 3 years ago

timmb commented 3 years ago

First step towards Windows compatability. Currently only the signalflow project (i.e. not examples) has been updated. Instructions for building are in the readme.

ideoforms commented 3 years ago

Ah, that's right @timmb - the if (CMAKE_BUILD_PYTHON) stanza in CMakeLists needs to be somewhere before the add_library(signalflow SHARED ${SRC}) line to avoid build errors. This is because of the way that macOS handles resolving dynamic libraries at build time, which is what the -undefined dynamic_lookup line is there for. A bit of info here if you're interested:

https://blog.tim-smith.us/2015/09/python-extension-modules-os-x/

It's probably best moved to right after the CMAKE_BUILD_TYPE blocks (line ~52) I made this change locally and it now builds and runs without problems 🎉