search

ideoforms / signalflow

A sound synthesis framework for Python, designed for clear and concise expression of complex musical ideas
https://signalflow.dev
MIT License
167 stars 14 forks source link

Enable building on intel mac #90

Closed acarabott closed 1 year ago

acarabott commented 1 year ago

Specifying arm64 causes builds to fail on intel macs. With ARCHS_STANDARD CMake will make a Universal build by default, but will work on intel macs.

acarabott commented 1 year ago

OK it looks like I jumped the gun on this and the real blocker to building was something else.

This PR has an error, it uses ${ARCHS_STANDARD} instead of the correct value of $(ARCHS_STANDARD). The reason it still worked was ${ARCHS_STANDARD} is a CMake variable, and is set to "" by default.

The parentheses version will work correctly if using Xcode or Makefiles as your build system, but fails with ninja (default build system for CLion).

I suggest reverting this back to "arm64;x86_64", which will build on an intel machine.

Apologies for the confusion!