ideonate / cdsdashboards

JupyterHub extension for ContainDS Dashboards
https://cdsdashboards.readthedocs.io/
Other
201 stars 37 forks source link

Adding support for conda_envs trait as callable #104

Closed costrouc closed 2 years ago

costrouc commented 2 years ago

Closes #103

@danlester wanted to start off a PR that will give support for making conda_envs update via a callable function. Happy for feedback. I'm not to happy with my approach of creating a property _conda_envs.

danlester commented 2 years ago

I think it's fine if it works! But if you don't like the property, since it's only called once, why not just spell out the contents of that method where it's used instead?

costrouc commented 2 years ago

@danlester I changed this PR to instead like you recommended. Let me know your thoughts. Otherwise I think this PR is ready