ideonate / cdsdashboards

JupyterHub extension for ContainDS Dashboards
https://cdsdashboards.readthedocs.io/
Other
200 stars 38 forks source link

[DOC] Add conda install command #18

Closed fcollonval closed 4 years ago

fcollonval commented 4 years ago

Hey,

The all stack is almost on conda-forge: https://github.com/conda-forge/jhsingle-native-proxy-feedstock https://github.com/conda-forge/bokeh-root-cmd-feedstock https://github.com/conda-forge/plotlydash-tornado-cmd-feedstock https://github.com/conda-forge/cdsdashboards-feedstock

Still missing r-shiny command: https://github.com/conda-forge/staged-recipes/pull/12075

And I don't like to add voila-materialstream as package should be as unitary as possible.

Two questions/comments:

danlester commented 4 years ago

Thanks for all of this.

Yes please do add me as a maintainer - I think it makes sense, but for now I'm not planning to interfere :)

The docs changes are great, and I will check and copy into The Littlest JupyterHub setup too.

I recently changed voila-materialstream so that it doesn't actually install Voila anymore. So maybe this will be more acceptable now. But to be honest, voila-materialstream is a problem in general. If not installed then Voila dashboards will break by default... maybe it would be safest to drop voila-materialstream as a default template, but cdsdashboards is a lot of people's first introduction to Voila so I think it makes sense to make it look nice.

Perhaps I need to introduce an option in Voila upstream so that it just reverts to the default template if the specified one is not found.

Dan

fcollonval commented 4 years ago

Hey thanks for the quick answer. You should get some spam soon due to your new maintainer status 😉

I need to introduce an option in Voila upstream so that it just reverts to the default template if the specified one is not found.

Would it be easy to get the list of the available voila template and raise an error if the chosen one is not available?

From what I saw, voila templates are not Python packages (they don't contain any python code). So this may be a complex task.

danlester commented 4 years ago

It would be possible for e.g. jhsingle-native-proxy to check this, in the same way that Voila has to search for the template, but I think it would be best if Voila can handle this.