search

ideonate / cdsdashboards

JupyterHub extension for ContainDS Dashboards
https://cdsdashboards.readthedocs.io/
Other
200 stars 38 forks source link

Removing Named Server functionality not working as described #45

Closed parodayco closed 3 years ago

parodayco commented 3 years ago

Describe the bug Adding the following to my cdsdashboards_config.py and reloading per the Hub Options: Named Server display documentation does not work.

c.JupyterHub.template_vars = {
    'cds_hide_user_named_servers': True,
    'cds_hide_user_dashboard_servers': True
    }

To Reproduce nano /opt/tljh/config/jupyterhub_config.d/cdsdashboards_config.py add code above and save sudo tljh-config reload ...and log back in as regular user. I expect the New Dashboard option to be hidden but instead I see the following:

Screenshots

image

Configuration see above

p.s. Thank you so much for creating this addition to Jupyterhub, it's wonderful!

danlester commented 3 years ago

Thank you for your issue - I'm pleased to hear you like the extension!

Sorry for any confusion, but I think it is possible that those settings are working as I intended... they should affect what the user sees on their home page (/hub/home) and not on the Dashboards page (/hub/dashboards).

image

Beneath the two big buttons at the top:

cds_hide_user_named_servers=True would hide the Named Servers section. cds_hide_user_dashboard_servers=True would hide the Dashboard Servers section.

I imagine you are hoping to create users who are only present to view dashboards (e.g. non-technical users) and who you don't want to create dashboards or servers. I think that's really important. There is some work already carried out to make this possible, and I hope to be able to work on it over the next few weeks. The issue is https://github.com/ideonate/cdsdashboards/issues/37