search

ideonate / cdsdashboards

JupyterHub extension for ContainDS Dashboards
https://cdsdashboards.readthedocs.io/
Other
200 stars 38 forks source link

Fix Panel Launcher #85

Closed MarcSkovMadsen closed 3 years ago

MarcSkovMadsen commented 3 years ago

I believe {--}panel should be changed to '{--}server=panel. I've not been able to test it though.

danlester commented 3 years ago

Yes, I think you're right - maybe we changed it during development of bokeh-root-cmd.

danlester commented 3 years ago

Actually, the latest version of cdsdashboards code already contains this update -i.e. it uses --server=panel.

So I'll close without merging because I think we already have your change!

danlester commented 3 years ago

https://github.com/ideonate/cdsdashboards/blob/87c65eb4e54ea9772578ef2bbc396e95f4b43937/cdsdashboards/hubextension/spawners/variablemixin.py#L82

MarcSkovMadsen commented 3 years ago

Thanks. By the way I've gotten it working on our Jupyter hub and it works great.