search

idesis-gmbh / png2icons

Create Apple ICNS and Microsoft ICO files from PNG
MIT License
105 stars 10 forks source link

Support SVG? #10

Open qwertychouskie opened 5 months ago

qwertychouskie commented 5 months ago

Generally, the accepted best practice if you have an SVG is to export that SVG at each native size needed. Right now I have to export the SVG as a PNG separately then use this to convert it to ico/icns, resulting in a small quality loss.

mn4367 commented 4 months ago

Thanks for your suggestion! One key feature of png2icons is that is has no dependencies and I'm reluctant to change this. Supporting SVG would need to include modules like canvas or sharp which makes it nearly impossible to create self-contained executables. The same is true for the myriad of other image formats that some people might want to have supported.

For elephicon this is much easier to implement since in Electron SVG rendering is available and with createImageBitmap it should be fairly easy to add this feature.

I'm leaving this issue open as a reminder but the chances that support for other image formats will find its way to png2icons are extremely low.