search

ideveCore / Valuta

This is a simple application for converting currencies, with support for various APIs.
GNU General Public License v3.0
15 stars 6 forks source link

Reconsider Google as a source #25

Closed bragefuglseth closed 2 months ago

bragefuglseth commented 8 months ago

The Google provider falls short in many ways, and often leaves the app hanging. Given that the data is retrieved in a pretty hacky way, maybe it should be considered removed from the app altogether? ECB seems like a trustworthy and stable alternative, and other providers could always be added.

ideveCore commented 7 months ago

I was inclined to remove it, but not now. However, if it's truly necessary, I will remove it.

ideveCore commented 5 months ago

Hello, there are currently users who use the app and convert currencies that ECB does not support. I know that the Google provider is being used in a hacked way, but removing it now without prior notice to the users would render the app useless for some users currently.

bragefuglseth commented 5 months ago

If the additional currencies it provides are worth the instability to some people, maybe keeping it as an option while marking it as unstable would be a sufficient compromise?

bragefuglseth commented 5 months ago

Also, I've found that when the app first hangs, it needs to be restarted to perform more conversions. Is it possible to make the app recover more gracefully from those situations?

ideveCore commented 2 months ago

Hello, I believe this has already been resolved. I will be closing this issue.