search

idflood / ThreeNodes.js

vvvv "clone" in javascript/webgl
http://idflood.github.com/ThreeNodes.js/
Other
2.18k stars 316 forks source link

Uncaught RangeError: Maximum call stack size exceeded #7

Closed zz85 closed 12 years ago

zz85 commented 12 years ago

Quite often I encounter this error in Chrome when clicking on some of the properties on the node. Not sure why, and I end up refreshing the page..

idflood commented 12 years ago

Hi, I've already encountered this error some time ago when doing a large refactoring. But I tried today to reproduce the error without success.

Could you give more precision on which nodes and fields caused this issue?

kenpratt commented 12 years ago

I was running into this problem as well. It seems to happen anytime you create an invalid connection in the diagram.

Simple way to reproduce: 1) Start with a blank canvas 2) Drag a Number onto the canvas 3) Click on "in" 4) Click on "out" 5) You should see the exception in your console

Another way: create a Number and a Vector, hook the x input of the vector up to the input of the number.

(on Chrome 15 on Mac)

idflood commented 12 years ago

Thanks, i forgot to test with "wrong connection". I added some simple tests and made them pass with a basic connection validation. Here are the commits, the first one add the tests and the second make them pass: https://github.com/idflood/ThreeNodes.js/commit/ddb21140cc0da94cb544d09169d94bea701ec26c https://github.com/idflood/ThreeNodes.js/commit/ef5f6bacc50f64301789a2299f25c3c3d674c643

There are still possible issues when connecting wrong field types between them so I will keep this issue open.

idflood commented 12 years ago

I haven't seen this error in a while so closing this issue. Feel free to open another one if needed.

zz85 commented 12 years ago

:)