idiap / coqui-ai-TTS

🐸💬 - a deep learning toolkit for Text-to-Speech, battle-tested in research and production
https://coqui-tts.readthedocs.io
Mozilla Public License 2.0
497 stars 49 forks source link

torch>=2.4 dependency in dev means no support for Intel Macs #112

Open ajkessel opened 1 week ago

ajkessel commented 1 week ago

Describe the bug

torch stopped building for Intel Macs after 2.2.2. coqui-tts main branch still installs because it only requires torch>=2.1, but on dev you are requiring torch>=2.4, and thus it cannot be installed even on a relatively recent Mac (e.g. iMac (Retina 5K, 27-inch, 2020)). Do you need the >=2.4 requirement or could it be loosened?

To Reproduce

Attempt to install from dev

Expected behavior

No response

Logs

No response

Environment

{
    "CUDA": {
        "GPU": [],
        "available": false,
        "version": null
    },
    "Packages": {
        "PyTorch_debug": false,
        "PyTorch_version": "2.2.2",
        "TTS": "0.24.2",
        "numpy": "1.26.4"
    },
    "System": {
        "OS": "Darwin",
        "architecture": [
            "64bit",
            ""
        ],
        "processor": "i386",
        "python": "3.11.10",
        "version": "Darwin Kernel Version 24.0.0: Tue Sep 24 23:36:30 PDT 2024; root:xnu-11215.1.12~1/RELEASE_X86_64"
    }
}

Additional context

No response

eginhard commented 1 week ago

Yeah, I agree it's not ideal. I've started adding some conditional handling for the code that needed this in https://github.com/idiap/coqui-ai-Trainer/pull/11, after which I can do the same in this repo (#113) and go back down to 2.1