search

idibidiart / react-native-responsive-grid

Bringing the Web's Responsive Design to React Native
Other
379 stars 42 forks source link

helpers.js uses module.exports while Column.js uses imports #40

Closed skylinezum closed 4 years ago

skylinezum commented 4 years ago

Mixing module.exports and import instead of require causes many problems. Better to just used a named export for each function

export const <function name>
idibidiart commented 4 years ago

Hi,

Please feel free to submit a pull request, but I’ve not been a maintainer on this project for a while now. @peacechen Maybe you’d care to look into it , too?

Thank u.

skylinezum commented 4 years ago

Hi,

I made a PR already -> PR

idibidiart commented 4 years ago

Great. I have no way to test it unless I setup an RN environment again. Will wait first on @peacechen to see if he can test and merge.

Thanks again. Much appreciated.

peacechen commented 4 years ago

Thanks @skylinezum for the PR. Tested it and works greatđź‘Ť

peacechen commented 4 years ago

@idibidiart Would you publish a new version on npm? It's been a while.

innerop commented 4 years ago

@peacechen sure, I'll clone and publish later today. Will ping here. Thanks!!

shiundu commented 4 years ago

Has this been fixed in the current version?

./node_modules/react-native-responsive-grid/src/components/Column.js
Attempted import error: 'getOffset' is not exported from '../lib/helpers'.

I am having issues with export/import

idibidiart commented 4 years ago

No I was supposed to publish it a while ago,

Problem is I no longer have the RN environment to test the latest commit but I’ll do an npm push (tonight) based on @peacechen ’s test.

idibidiart commented 4 years ago

Sorry for the terribly long delay.

idibidiart commented 4 years ago

Finally, published

Sorry about that. Closing now.

$ npm publish npm notice npm notice 📦 react-native-responsive-grid@0.41.993 npm notice === Tarball Contents === npm notice 7.5kB src/components/Column.js npm notice 1.9kB src/components/Grid.js npm notice 4.6kB src/lib/helpers.js npm notice 224B src/index.js npm notice 6.1kB src/components/Row.js npm notice 4.2kB src/lib/ScreenInfo.js npm notice 948B package.json npm notice 5.7kB CHANGELOG.md npm notice 5.1kB CONTRIBUTING.md npm notice 3.7kB DesignPrinciples.md npm notice 13.4kB EvenMoreExamples.md npm notice 155B .github/ISSUE_TEMPLATE.md npm notice 1.2kB LICENSE.md npm notice 33.2kB README.md npm notice 6.9kB UniversalPinterestLayout.md npm notice 2.9kB UniversalTiles.md npm notice === Tarball Details === npm notice name: react-native-responsive-grid npm notice version: 0.41.993 npm notice package size: 25.2 kB npm notice unpacked size: 97.8 kB npm notice shasum: 5d84e4340e67c5888b38939cc3496ae5942dae13 npm notice integrity: sha512-vyFXRArmYoXZm[...]YS8oPZDlhFyGw== npm notice total files: 16 npm notice