search

idio / json-wikipedia

Json Wikipedia, contains code to convert the Wikipedia xml dump into a json dump. Questions? https://gitter.im/idio-opensource/Lobby
17 stars 2 forks source link

Fix surefire booter forked booter issue #56

Closed exegetics closed 6 years ago

exegetics commented 6 years ago

solves issue idio/json-wikipedia/issues/55

connects #55

tgalery commented 6 years ago

so, it seems that this has been branched of dev and you want to merge it to master. Ideally this would be a hotfix, but looking at the stack overflow discussion it seems that it is a jdk bug ? I wonder whether upgrading the jdk in chef as part of https://github.com/idio/chef/pull/1938 might be better ?

exegetics commented 6 years ago

so, it seems that this has been branched of dev and you want to merge it to master. Ideally this would be a hotfix, but looking at the stack overflow discussion it seems that it is a jdk bug ? I wonder whether upgrading the jdk in chef as part of idio/chef#1938 might be better ?

This strategy requires a downgrade in JDK (see http://bugs.debian.org/911925) @tgalery Two questions:

  1. which do prefer downgrade JDK or modification to pom.xml as it stands?

  2. Hotfix or regular merge

tgalery commented 6 years ago

I'm happy as is, but this needs to be a hotfix.

exegetics commented 6 years ago

New pull request for a hot fix