Closed dav009 closed 10 years ago
The only comments I could give would be related to refactoring the code a bit using styling conventions, which brings me to the that fact that maybe we should write a style-guide for Scala? However, I think this would be more of a pain when you rebase the new model editor after you merge this pr. So you are good to go.
I've been taking a look at: http://docs.scala-lang.org/style/
part of that job is being done in the new branch, as I refactored for quantized I've been changing the style
Looks good
We had a case in which we wanted to have all the candidate topics of a surface form associated with a different surface form.
Previously when we had similar cases we would just create a file with the associations we wanted to create. The problem with this approach is that the original
candidate counts
are lost. this loss affects the final spot if the number of candidate topics for a singleSF
is long.So this PR introduces:
copy-candidates
)candidate count
value will be the average of thecandidate counts
for the selected surfaceFormidioCandidateStore
's constructor, so that unit-tests could be added.