idio / spotlight-model-editor

Tool for tweaking dbpedia spotlight's models
Apache License 2.0
16 stars 8 forks source link

Feature/copy associations #2

Closed dav009 closed 10 years ago

dav009 commented 10 years ago

We had a case in which we wanted to have all the candidate topics of a surface form associated with a different surface form.

Previously when we had similar cases we would just create a file with the associations we wanted to create. The problem with this approach is that the original candidate counts are lost. this loss affects the final spot if the number of candidate topics for a single SF is long.

So this PR introduces:

tgalery commented 10 years ago

The only comments I could give would be related to refactoring the code a bit using styling conventions, which brings me to the that fact that maybe we should write a style-guide for Scala? However, I think this would be more of a pain when you rebase the new model editor after you merge this pr. So you are good to go.

dav009 commented 10 years ago

I've been taking a look at: http://docs.scala-lang.org/style/

part of that job is being done in the new branch, as I refactored for quantized I've been changing the style

SoAG commented 10 years ago

Looks good