Closed phdowling closed 6 years ago
looks good :+1: sorry for the late comment.
could you please squash some of the commits (for example: local fixes
x 3)
Ah, this is awful. I tried to squash and rebase, it seems to have just added more commits now
edit: looking better now. @dav009 feel free to review again and merge when ready
oops, git rebase -i HEAD~20
<- squashing.
Is it looking okay now?
@dav009 Just came across this again, any reason you don't want to merge? I think this improves the quality of the data a fair bit
hi @phdowling @dav009 is in Japan atm, this repo is kind of not very well maintained as we might re-write it from scratch. That being said, I'll take a look at it when I have time, and probably merge.
These are some changes I made that seem to improve corpus and model quality. I also added a script that converts the vectors to a csv format that can be used by Spotlight to create a vector store.