search

idiomatic / HandyNotes_Achievements

Shows location of incomplete World of Warcraft achievements
Apache License 2.0
2 stars 6 forks source link

git submodule some of the things #21

Closed idiomatic closed 3 years ago

idiomatic commented 3 years ago

ala LibQTip.

idiomatic commented 3 years ago

alas, the Ace3 suite is in Subversion.

JanGalek commented 3 years ago

https://github.com/wowace-clone/Ace3 ;)

idiomatic commented 3 years ago

will splinter InSeason and InstanceLocations at a later time (or as they say, "in post").

idiomatic commented 3 years ago

Pardon the redundancy, but because of the Subversion-origination of authentic Ace3, and authenticity-concerns of @wowace-clone, we may wish to revert #23.

JanGalek commented 3 years ago

I'm reverting it ;) and updating Ace3 ;)

idiomatic commented 3 years ago

Reverting, or shifting the dependency elsewhere?

opinion:

Sometimes the complexity added by using libraries or frameworks exceeds the complexity provided. I'm personally a fan of studying how the library or framework works, and extracting -- or in essence freezing -- the important, useful bits. While the underlying WoW runtime API may change, so may the library or framework API, jeopardizing the value-proposition of the "middleman". The development of HandyNotes_Achievements evolved to be increasingly conservative as a defense to API-drift and abstraction-impedance.

In my opinion, using libraries, frameworks, and even submodules is complexity of dubious benefit and each exception should be scrutinized. My immediate concern is that the Makefile's blind git submodule update on publish (a hack around the complexity I reluctantly added to submodularize AchievementLocations) is increasingly risky as the dependence of submodules whose API may change without warning increases.