idiomatic / HandyNotes_Achievements

Shows location of incomplete World of Warcraft achievements
Apache License 2.0
2 stars 6 forks source link

update instance locations #22

Open idiomatic opened 3 years ago

idiomatic commented 3 years ago

surely more instances and map zones have been introduced during my hiatus.

JanGalek commented 3 years ago

@idiomatic I can help, I see InstanceLocations, but I dont know how get coors X,Z and I'm not sure how get mapfile too

idiomatic commented 3 years ago

Based on wowwiki, try going to an instance door and:

/script SetMapToCurrentZone() local x,y=GetPlayerMapPosition("player") DEFAULT_CHAT_FRAME:AddMessage(format("%s, %s: %.3f, %.3f",GetZoneText(),GetSubZoneText(),x,y))

Some reverse engineering of HandyNotes may be necessary for deep understanding of mapfile. Alternatively, experimentation with the map API could yield results.

JanGalek commented 3 years ago

Message: [string "SetMapToCurrentZone() local x,y=GetPlayerMa..."]:1: attempt to call global 'SetMapToCurrentZone' (a nil value)

idiomatic commented 3 years ago

Or in WoW 8.0 or later:

/script print(C_Map.GetPlayerMapPosition(C_Map.GetBestMapForUnit("player"), "player"):GetXY())
idiomatic commented 3 years ago

I'm contemplating looking for some old WowLua SavedVariables files for other small code snippets. However, they will be of limited use as they may be from before the 8.0 API changes.

JanGalek commented 3 years ago

I see HandyNotes using https://github.com/Nevcairiel/HereBeDragons but there is missing BFA mapFiles :/

idiomatic commented 3 years ago

I suggest delaying updating instance locations. The instance locations matter when #20 adds reference to instances.