idiomatic / HandyNotes_Achievements

Shows location of incomplete World of Warcraft achievements
Apache License 2.0
2 stars 6 forks source link

add version number to release archives #32

Closed idiomatic closed 3 years ago

idiomatic commented 3 years ago
idiomatic commented 3 years ago

considering adding to the Publish workflow:

- name: version
  run: echo "::set-output name=VERSION::$(make version)"
  id: version

and

ARCHIVE: HandyNotes-Achievements-${{ steps.version.outputs.VERSION }}.zip

But there's a chicken-and-the-egg problem where the actions runner provides the ARCHIVE environment variable to the step subprocesses. The work-around would be to inline the ARCHIVE value interpolation into the dependent steps run scripts (i.e., archive and upload_curseforge, which currently get it implicitly from env).

This solution is relatively verbose at multiple stack levels, and has a steep learning curve.

idiomatic commented 3 years ago

alternatively, considering removing ARCHIVE assignment from the Publish workflow and burying it into the Makefile level. this is simpler to implement, but goes in the wrong direction vis a vis transparency and high-level configurability (something that gets more critical if there are additional publish destinations).

idiomatic commented 3 years ago

Done.

image