Closed v3nd3774 closed 4 years ago
@kmeng01 @damianj @824zzy @YapheeetS could you take a look at this when you get a chance and create a list of issues in this thread?
I can help with some of these
barring the bugs, this looks pretty much like what we wanted! thanks for the hard work josh :)
@kmeng01 I've addressed some of the issues you've mentioned. I had a :question: on one:
Is there different behavior you'd prefer?
Wow, this looks really great!! Most of the bugs are gone :D
What I meant by the county thing was that, when you click on a county on the sidebar, shouldn't the interface drop down another level to show the county and its detailed stats? Because when you click on a county on the map, it should show that county's name and stats, but currently it doesn't move at all.
I figure that the easiest way to accomplish this would be to allow the sidebar to drop down such it shows global -> us -> state -> county.
would you guys agree?
Also, it seems like when you click on a county (whether the sidebar or on the map) it throws an error
To elaborate on that point about the counties, if you click on a county and then hit "x" on United States and then click on a county on the map again, it breaks the system
So it would probably be best to keep things consistent (actually run the query down to the county level)
Ok, I was working on enabling users to traverse all the way down to the counties, but when I'm sending the query I'm getting back some error. I want to be sure that for Karnes County, Texas the parameters are like this:
http://localhost:2222/api/v1/statquery?node=Karnes%20County-Texas&date=2020-04-11&dsrc_global=JHU&dsrc_country=JHU&dsrc_state=JHU&dsrc_county=JHU
I'm using that query string and seeing these results:
Could you help me construct that query string @kmeng01 ?
sure, let me take a look. thank you for letting me know about this!
I have a bug. If you click on a state (map), then click on the x on United States (to go back to country level), then click on a county on the map of the already selected state then it doesn't create the breadcrumbs for country and state.
I think ideally, clicking on the x of united states would un-select the state/country on the map. If that is too hard to implement though, I think at least clicking on the county should generate the two bread-crumbs.
hm, it's working for me
I think @824zzy might have input on how to do the zooming
One thing we might be able to do is that when a user clicks on the left side panel, you zoom to that location. Does that sound feasible? @824zzy
Okay, I see it throws out this error. I suppose the code on the dev server just hasn't been updated
@damianj I've updated the server to show changes at at https://idir.uta.edu/covid-19-dev/
@damianj @824zzy @YapheeetS can you guys take a look? please let us know of any remaining UI/api bugs, so perhaps we can merge it soon and continue work on other features. thank you!
lgtm