search

idirlab / covid19

GNU General Public License v3.0
2 stars 0 forks source link

storing working hospital pane #5

Closed v3nd3774 closed 4 years ago

v3nd3774 commented 4 years ago

Added css and js changes to render hospitals on county click and to hide them on a non county clicks.

Please review/merge or provide feedback.

kmeng01 commented 4 years ago

Looks good! Although it took a while for me to test :P

One thing: if you look at the screenshot I attached, it seems like the height is not being calculated correctly - the pane flows off the page. Perhaps we can kill two birds with one stone by simply having the pane the full height of the screen (just like the county selector): 1) hopefully it's easier to code and 2) it gives me more space to integrate the Twitter data as well.

How does that sound? Thanks so much for your hard work :)

Screen Shot 2020-04-04 at 7 56 32 PM

824zzy commented 4 years ago

Thanks Josue! The height problem that Kevin mentioned can be solved by changing value of div.smaller{... top: 256px;} ==> div.smaller{...top: 95px;}

I have tried on my local machine. It looks very good. image Is that what @kmeng01 you want?

v3nd3774 commented 4 years ago

I think I've made the requested changes to the height @kmeng01 and @824zzy. How does this look?

ezgif-3-77bbe8bc8a8f

v3nd3774 commented 4 years ago

@kmeng01 and @824zzy when y'all get a chance could y'all comment on the changed height of the hospital pane?