search

idirlab / covid19

GNU General Public License v3.0
2 stars 0 forks source link

Twitter view feature #54

Closed v3nd3774 closed 3 years ago

v3nd3774 commented 3 years ago

DO NOT MERGE WORK IN PROGRESS

v3nd3774 commented 3 years ago

Initial draft with color coding based on stance in .csv files:

Screen Shot 2021-01-23 at 10 32 02 AM

v3nd3774 commented 3 years ago

Live on the dev endpoint here.

v3nd3774 commented 3 years ago

@824zzy can you take a look and let me know if this covers the twitter feature or if we need additional changes?

ezgif-3-1b5b33e6b356

Clicking the distribution bar triggers the tweet view.

824zzy commented 3 years ago

Sure, I am checking now!

824zzy commented 3 years ago

The feature is exactly what I have in mind! But there are still some small changes I would prefer, we can discuss here.

  1. It is not clear to users that they can click any button in the Twitter stance distribution area to see all the matched tweet-fact pairs. To solve this problem, do you think we can simply create a new button to notice user they can see all the matched tweet-fact pairs via this button. The diagram below shows what I have in mind, what do you think? p.s.: We still keep our changes to let users see all the matched tweet-fact pairs by current buttons. image

  2. I also notice that in the top-right corner, our line chart's date is incorrect, it seems like the chart doesn't read data correctly and the global chart only up to Oct 27th. You can check Haojin Liao's(YapheeetS) commit history if you have extra energy and time, otherwise, I can take a look into this issue!

  3. BTW, it seems like the previous jhu_g date issue got fixed by changing the date format related codes, that's nice~

Thank you for your contribution!

v3nd3774 commented 3 years ago

Same functionality as before, but now thanks to 99e41a6 the view is triggered by new button. The Read more... was moved to the right hand side.

Screen Shot 2021-01-26 at 10 04 55 PM

v3nd3774 commented 3 years ago

global data now read even if data for a specific day is missing

Screen Shot 2021-01-26 at 10 31 47 PM

v3nd3774 commented 3 years ago

Deployed on https://idir.uta.edu/covid-19-dev/

@824zzy could you take a look and provide feedback on whether these changes address the issues 1 and 2 in your previous comment?

824zzy commented 3 years ago

Thank you, Josue. This feature perfectly fulfills the request! Let me just merge it and deploy it to production server.