search

idkr-client / idkr

:video_game: idk, just a Krunker client
GNU Affero General Public License v3.0
55 stars 37 forks source link

console is being spammed on latest master #33

Closed KraXen72 closed 3 years ago

KraXen72 commented 3 years ago

there are 10 console warns every second which slows down the client a lot on latest master. image

i temporarily fixed it by adding console.warn = () => {} but that's not a real solution. please fix the source of this warn. thanks

NullDev commented 3 years ago

The "source" of this warning is in Krunkers code. Not much we can do about it except hiding it or nulling out the caller.

The reason why this error shows up on idkr, is because we re-bind the original console object from Krunker: https://github.com/Mixaz017/idkr/blob/master/app/preload/global.js#L157-L158

That warning happens on every client and on every browser. It's just hidden.

KraXen72 commented 3 years ago

oh, interesting. i know that krunker disabled console logging (which is not a particualrly nice thing to do), and i didn't think reenabling was possible but here we are? anyway thank you for clarifying. i'd just suggest binding the old console to some custom object that only idkr uses so krunker doesen't have the console but idkr does

Mixaz017 commented 3 years ago

What. Krunker logs are as important as idkr logs.