search

idkr-client / idkr

:video_game: idk, just a Krunker client
GNU Affero General Public License v3.0
56 stars 37 forks source link

Adblock? #66

Closed GanerCodes closed 2 years ago

GanerCodes commented 2 years ago

Can this be added?

Mixaz017 commented 2 years ago

If you just want to hide ads, it's possible with userscripts (or css). Not planned to be a built-in feature for now.

GanerCodes commented 2 years ago

is there a way to launch it with a crx extension somehow attached to it? or compiled in?

Mixaz017 commented 2 years ago

https://www.electronjs.org/docs/latest/api/extensions Loading Chrome extensions is only partially supported by Electron (the framework used by most clients).

Mixaz017 commented 2 years ago

To add some more info: "True" adblocking in a form of blocking web requests for ad URLs and fixing broken layout caused by missing requests, is a lot of effort. Especially if we had to maintain list of ad URLs (which is definitely never going to happen). Fortunately there are some publicly available filter lists such as https://easylist.to/ , but we have to make a parser for it. There was https://github.com/brave-experiments/ad-block but the project is archived. If someone is motivated enough to implement a parser for the client, built-in adblocking might happen.

GanerCodes commented 2 years ago

alright I got an adblocker working. The extension method didn't do anything but this package works flawlessly https://github.com/ghostery/adblocker/tree/master/packages/adblocker-electron#usage