idleberg / sublime-icon-fonts

Completions for popular icon fonts such as Font Awesome, Glyphicons and many more!
MIT License
73 stars 11 forks source link

Completion does'nt work correctly in CSS Scope #10

Closed mschick closed 7 years ago

mschick commented 7 years ago

Completion only works outside CSS-Classes: Example:

.class {  
    fa-star + tab (or even with ctrl + space) leads to nothing...  
}

or

.class { 
     content: 'fa-star + tab'; epands to 
  -> content: 'content: '\f005';'; 
}
.class { ... }
fa-star + tab 
.class2 { ... }

expands to -> 

.class { ... }
 content: '\f005';
.class2 { ... }
idleberg commented 7 years ago

It's true that these completions should be scoped more strictly. Rather than using source.css, it should be source.css meta.property-list.css as this screenshot shows:

screen shot 2017-01-31 at 13 51 49

However, when I use this scope, the completions don't get triggered at all, so this is –to my understanding– an issue with the CSS package and should be posted here.

Once that is resolved, I will change the scope to source.css meta.property-list.css, source.less, source.scss meta.property-list.scss, source.stylus. Until then, the only work-around I can think of is using SCSS for CSS files.

idleberg commented 7 years ago

I've posted an issue here. In the meantime I have modified the default scope for all CSS completions in the master.

idleberg commented 7 years ago

I have converted all completions into snippets, which should circumvent the issue. In a next step, I will switch to a custom completions format.

idleberg commented 7 years ago

@mschick Can we close this issue?

mschick commented 7 years ago

Yes. Thank you!

Jan T. Sott notifications@github.com schrieb am So., 2. Apr. 2017, 15:29:

@mschick https://github.com/mschick Can we close this issue?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/idleberg/sublime-icon-fonts/issues/10#issuecomment-290986476, or mute the thread https://github.com/notifications/unsubscribe-auth/AFeNBJwl734UOCbPEKOFwmImy-3FQ14Eks5rr6KLgaJpZM4Lyblv .