idleberg / sublime-icon-fonts

Completions for popular icon fonts such as Font Awesome, Glyphicons and many more!
MIT License
73 stars 11 forks source link

fix wrong complete in php #5

Closed ghost closed 8 years ago

ghost commented 8 years ago
$this->model->query()
    [cursor here]->select()->get()

When cursor in above position, press tab it will complete cdnjs css

ghost commented 8 years ago

Hey @idleberg why u close this pr ?

idleberg commented 8 years ago

I appears to me that this is a problem caused by incorrect usage. There are probably conflicting situations, but I couldn't possibly address all of them. Why do you press Tab when you don't to complete? You can always press Esc to avoid the completion shown in the completion pop-up. Likewise, you can always select a different completion from that pop-up.

If you still think there's reason to exclude an entire scope, meaning that nobody will ever be able to use these completions, please provide some arguments that aren't based on a single case.

ghost commented 8 years ago

Have you ever write php code ? When u write a long query builder and want to make it look better, just break lines before -> Like jquery $(selector).find(sub)[ you want to break line here then press a TAB].addClass(cls).doSomething()

Press tab there to indent, not to get autocomplete and it does not show any suggestion before i press tab.

idleberg commented 8 years ago

Press tab there to indent, not to get autocomplete and it does not show any suggestion before i press tab.

As I've already suspected, your "problem" is rooted in your Sublime Text setup. You should probably adjust your auto_complete_selector setting to display the completion pop-up for the embedding.php scope.

Have you ever write php code ?

FYI: I went as far as trying to reproduce the example from your initial comment, but I cant even reproduce the problem.

ghost commented 8 years ago

Ok i got it