idleberg / vscode-emoji-code

Snippets to insert escaped Emoji code into HTML, CSS, JavaScript, Python and Ruby
https://marketplace.visualstudio.com/items?itemName=idleberg.emoji-code
MIT License
26 stars 4 forks source link

Typescript support #9

Closed JasCodes closed 6 years ago

JasCodes commented 6 years ago

Allow correct expansion in typescript.

idleberg commented 6 years ago

Allow correct expansion in typescript.

Hey, thanks for the support, but I'm not sure what the message above means. Is there anything wrong with the existing support for TypeScript?

JasCodes commented 6 years ago

Hey @idleberg In my vscode typescript context was expanding to hexadecimal format 0x000000.

Thx

idleberg commented 6 years ago

Can you please provide an example? Also, if that was true, I don't see how your PR would fix it. The content of emoji-javascript.json and emoji-typescript.json would be identical.

JasCodes commented 6 years ago

Oh, I didn't even tried in js 😝; assumed it kinna worked.

Here wat i am getting screenshot_2018-07-14 01 46 55_mqxtsq screenshot_2018-07-14 01 47 00_xj33ep

Thx

idleberg commented 6 years ago

I think the problem was caused by vsce and should be fixed in v0.7.2

JasCodes commented 6 years ago

Oh cool!!