search

idleberg / vscode-innosetup

Language syntax and snippets for Inno Setup
https://marketplace.visualstudio.com/items?itemName=idleberg.innosetup
MIT License
19 stars 6 forks source link

Quotes in AppName or in Task description break syntax highlighting #9

Open Ldoppea opened 6 years ago

Ldoppea commented 6 years ago

Hi,

This is related to https://github.com/idleberg/vscode-innosetup/issues/1

Syntax highlighting is also broken when you add simple quotes (used for French Apostrophes) for AppName : 

[Setup]
AppId={{C1E42BG7-455E-4251-8575-7BFG6ED4A1Y8}
AppName=Serveur d'impression

Same problem for Description and GroupDescription in Tasks.

[Tasks]
Name: MY_TASK; Description: Serveur d'impression; GroupDescription: Serveur d'impression; Flags: checkedonce exclusive

This may also be the case is some other elements but I did not tried everywhere. Those 2 cases are the one I need for my current project.

PS : Serveur d'impression is the french version of Print server

westr029 commented 4 years ago

Actually I don't know of any syntax highlighting that does this. Quotes are generally seen as indicator for a string. That is also how it works with this extension.

What could work in your case is to put " around the name. So that would make AppName="Serveur d'impression". On my local machine this works. So, not sure if this is really a bug.

idleberg commented 4 years ago

FYI, there is an open PR for (the compatible) TextMate INI syntax highlighter. It has never been accepted by the maintainer, but I've tried to implement the pattern for the Inno Setup config file. The fix doesn't work for me.

If anyone wants to look into this, the PR might be a good head start.