idlesign / django-sitetree

Reusable application for Django introducing site tree, menu and breadcrumbs navigation elements.
http://github.com/idlesign/django-sitetree
BSD 3-Clause "New" or "Revised" License
347 stars 132 forks source link

add missing migrations, check them during testing #312

Closed PetrDlouhy closed 1 year ago

coveralls commented 1 year ago

Coverage Status

Coverage remained the same at 95.89% when pulling abef5c65ae1cc23bcd09ab72647ddf6d746db975 on PetrDlouhy:fix_migrations into c0374f3a78a46467b290cd2935c16b66941f30f0 on idlesign:master.

PetrDlouhy commented 1 year ago

@idlesign I have added the check_migrations fixture to pytest_djangoapp: https://github.com/idlesign/pytest-djangoapp/pull/28 and rewrite the tests here.

But I tested this only by adding the code to conftest.py, because I was not able to use the modified pytest_djangoapp. It didn't find the fixture no matter how I tried to install the modified version.

idlesign commented 1 year ago

I have added the check_migrations fixture to pytest_djangoapp: https://github.com/idlesign/pytest-djangoapp/pull/28 and rewrite the tests here.

Thank you. Tests are failing there though. And docs update would be nice there too.

We'll release a new version after that pull request is merged and release a new version for sitetree and others to depend on.

PetrDlouhy commented 1 year ago

@idlesign I have changed the dependency for pytest-dangoapp to GIT repository. Now the tests are passing. Don't pull with the last commit, but otherwise it is ready once the pytest-djangoapp is released.

idlesign commented 1 year ago

djangoapp 1.0.0 is out

PetrDlouhy commented 1 year ago

@idlesign I removed the temporary commit. Now it should be ready.

idlesign commented 1 year ago

Thank you. Merged.

PetrDlouhy commented 9 months ago

@idlesign Do you have any plans for new release containing this PR, please?

idlesign commented 9 months ago

@PetrDlouhy Oh, I've thought is was done a long time ago. Thank you for the reminder. Sure, there will a release in a week. Just to make it more solid I want to add yet another feature.

PetrDlouhy commented 9 months ago

@idlesign Thank you very much.

idlesign commented 8 months ago

@PetrDlouhy

Finally 1.18.0 is out