search

idlesign / ist-yii-cfile

CFile provides popular functions to manipulate files both with Yii Framework and without
http://www.yiiframework.com/extension/cfile/
MIT License
57 stars 22 forks source link

Fixed "dead" test assertions #25

Closed Kolyunya closed 7 years ago

Kolyunya commented 10 years ago

There were "dead" assertions in tests which were never checked. The code after

$this->setExpectedException('CFileException');
throw new CFileException('');

is never executed. Tests with several "setExpectedException" should be split to work as expected with PHPUnit (at least with version 3.6.10).

There were 35 assertions before the commit. There are 39 assertions after the commit. By the way there are other "dead" tests assertions in the code which are not fixed yet since I am not sure if this is a real issue or I am missing something.

I am sorry but "testSetOwner_001" and "testSetOwner_002" fail on my Debian 7 x64 machine.

idlesign commented 10 years ago

Thank you for the report, I'll look into it in a couple of days.

idlesign commented 10 years ago

Sorry for the delay. You're right, those are dead indeed. Thank you. I have some notes though.