idlesign / pytest-djangoapp

Nice pytest plugin to help you with Django pluggable application testing.
https://github.com/idlesign/pytest-djangoapp
BSD 3-Clause "New" or "Revised" License
40 stars 6 forks source link

add check_migrations fixture #28

Closed PetrDlouhy closed 1 year ago

PetrDlouhy commented 1 year ago

@idlesign Now I hope the tests will pass. I have added also test for the case the migrations are missing and treated old Django versions (<2.0) which doesn't have --check option - the fixture will fail with helpful message.

P.S.: It would be quicker if I would not need to wait for the approval to run tests.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3421714413


Files with Coverage Reduction New Missed Lines %
pytest_djangoapp/fixtures/templates.py 1 90.48%
pytest_djangoapp/compat.py 2 66.67%
pytest_djangoapp/fixtures/request.py 2 89.86%
pytest_djangoapp/configuration.py 8 86.82%
<!-- Total: 13 -->
Totals Coverage Status
Change from base Build 2210969880: -1.4%
Covered Lines: 286
Relevant Lines: 297

💛 - Coveralls
coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3421714413


Files with Coverage Reduction New Missed Lines %
pytest_djangoapp/configuration.py 8 86.82%
<!-- Total: 8 -->
Totals Coverage Status
Change from base Build 2210969880: 0.3%
Covered Lines: 291
Relevant Lines: 297

💛 - Coveralls
idlesign commented 1 year ago

Thank you. Merged.

P.S.: It would be quicker if I would not need to wait for the approval to run tests.

Hm, I thought that GitHub does just that after the very first approval for a new contributor.