idlesign / torrentool

The tool to work with torrent files.
https://github.com/idlesign/torrentool
BSD 3-Clause "New" or "Revised" License
148 stars 30 forks source link

Add missing long for py2 and autoescape escape codes from filepaths in windows #3

Closed Hellowlol closed 8 years ago

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.7%) to 94.276% when pulling 99778780e9c52e99256f7d6b54b162125614043b on Hellowlol:master into 8073fc53c39debb2f141a511779224add3f949b7 on idlesign:master.

idlesign commented 8 years ago

Thank you. Please take a notice that some tests are failed on py3. This should be imporved before merge. Coverage is dropped too, so consider adding new tests.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.05%) to 95.987% when pulling 06fae12cdc447be2ead8dbebd6db4eb4d4e8a735 on Hellowlol:master into 8073fc53c39debb2f141a511779224add3f949b7 on idlesign:master.

Hellowlol commented 8 years ago

I can add some new tests however for this to work we need a bigger file so the filesize is long on python 2. Also tests for test_getters_dir and create_torrent fails on windows (unrelated to the pr)

idlesign commented 8 years ago

Great!

[...] we need a bigger file so the filesize [...]

Probably some kind of mock will do instead of a real file.

As for dir tests, if you have time you could fix it, as I have no Windows to check that out.

Hellowlol commented 8 years ago

I would like to get rid for .api file and just import it in the init file and at the same time redo all the tests and use pytest as i dont like unittest.

I just wanted to check if this is something you would accept before i start on a pr.

idlesign commented 8 years ago
Hellowlol commented 8 years ago

Awesome, thanks!

Hellowlol commented 8 years ago

Sorry for being a couchpotato. Ill fixup the windows test and send a new pr. Thanks for pytest commit. Saved me alot of work :P

idlesign commented 8 years ago

That's ok, pull requests are welcome %)