Closed Hellowlol closed 8 years ago
Thank you. Please take a notice that some tests are failed on py3. This should be imporved before merge. Coverage is dropped too, so consider adding new tests.
I can add some new tests however for this to work we need a bigger file so the filesize is long on python 2. Also tests for test_getters_dir and create_torrent fails on windows (unrelated to the pr)
Great!
[...] we need a bigger file so the filesize [...]
Probably some kind of mock will do instead of a real file.
As for dir tests, if you have time you could fix it, as I have no Windows to check that out.
I would like to get rid for .api file and just import it in the init file and at the same time redo all the tests and use pytest as i dont like unittest.
I just wanted to check if this is something you would accept before i start on a pr.
Awesome, thanks!
Sorry for being a couchpotato. Ill fixup the windows test and send a new pr. Thanks for pytest commit. Saved me alot of work :P
That's ok, pull requests are welcome %)
Coverage decreased (-1.7%) to 94.276% when pulling 99778780e9c52e99256f7d6b54b162125614043b on Hellowlol:master into 8073fc53c39debb2f141a511779224add3f949b7 on idlesign:master.