Preserve user-defined quality priorities

idlesign / torrt

Automates torrent updates for you

https://github.com/idlesign/torrt

BSD 3-Clause "New" or "Revised" License

112 stars 19 forks source link

Preserve user-defined quality priorities #44

Closed alexlitvinenko closed 5 years ago

alexlitvinenko commented 5 years ago

{self.sanitize_quality(pref) for pref in self.quality_prefs} is a set and it is not ordered. As a result torrt frequently picked quality with lower priority but higher-priority quality was available.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 70

19 of 20 (95.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 51.443%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
torrt/trackers/anilibria.py	19	20	95.0%
<!--	Total:	19	20	95.0%	-->

Totals
Change from base Build 68:	0.2%
Covered Lines:	731
Relevant Lines:	1421

💛 - Coveralls

idlesign commented 5 years ago

Thank you.

Could you also enchance the test suite (https://github.com/idlesign/torrt/blob/master/tests/trackers/test_anilibria.py) to cover that change for a regression?

alexlitvinenko commented 5 years ago

Done. Please review.

idlesign commented 5 years ago

Thank you. Merged.