Try to preserve list of unwanted files

idlesign / torrt

Automates torrent updates for you

https://github.com/idlesign/torrt

BSD 3-Clause "New" or "Revised" License

112 stars 19 forks source link

Try to preserve list of unwanted files #50

Closed alexlitvinenko closed 4 years ago

alexlitvinenko commented 4 years ago

Torrt always recreate a torrent and as a result doesn't preserve list of files that a user marked as "do not download".

This is a prototype for now. Are you OK to accept the feature?
This feature is applicable to transmission only. I'm not going to support other RPCs due to lack of API functions.
The approach is not precise. You cannot be 100% sure that it is the same unwanted file that it was before. Hashes and names can be updated.

idlesign commented 4 years ago

The feature is certainly nice. Something more advanced has been done in deluge-updatorr.
I'm also ok for now with Transmission only.
I'm worried about results stability, since, as you've mentioned files may change names etc.
I'm also not sure whether we should have a separate RPC method, may be enhanced add_torrent will suffice.
And unwanted probably needs to be renamed into something more neutral like excluded.

And another thing I want you to ask, before we move further: I'm now in the middle of https://github.com/idlesign/torrt/tree/feat/types let's wait when it's landed in master, because there are many lines changed and it's better to wait to not to have conflicts.

I'm also thinking about magnet support, so we'd probably need to think how all that stuff we've mentioned should fit together.

idlesign commented 4 years ago

I've merged type annotations: there are some corner cases but overal it's ready.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 98

8 of 28 (28.57%) changed or added relevant lines in 6 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.6%) to 52.549%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
torrt/rpc/deluge.py	1	2	50.0%
torrt/rpc/qbittorrent.py	1	2	50.0%
torrt/rpc/utorrent.py	1	2	50.0%
torrt/rpc/transmission.py	2	19	10.53%
<!--	Total:	8	28	28.57%	-->

Files with Coverage Reduction	New Missed Lines	%
torrt/rpc/transmission.py	1	28.24%
<!--	Total:	1		-->

Totals
Change from base Build 95:	-0.6%
Covered Lines:	773
Relevant Lines:	1471

💛 - Coveralls

alexlitvinenko commented 4 years ago

Something more advanced has been done in deluge-updatorr.

I switched from deluge to transmission because default deluge API doesn't support 'excluded files'.

I'm worried about results stability, since, as you've mentioned files may change names etc.

The following cases will not work:

A torrent creator decided to rename files, e.g. fix typo, replace underscore with hyphen, ....
Torrt hasn't found appropriate quality and used some other quality. As a result file names are different.

I'm also not sure whether we should have a separate RPC method, may be enhanced add_torrent will suffice.

Enhanced. See my comment.

And unwanted probably needs to be renamed into something more neutral like excluded.

Done. I took "unwanted" from transmission initially.

idlesign commented 4 years ago

Sorry for the delay. Thank you. Merged.