Closed NecroKote closed 2 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
torrt/bots/telegram_bot.py | 11 | 60 | 18.33% | ||
<!-- | Total: | 11 | 60 | 18.33% | --> |
Totals | |
---|---|
Change from base Build 1792897918: | -0.3% |
Covered Lines: | 1121 |
Relevant Lines: | 1656 |
Thank you. Please do not apply black formatting just yet. We'd rather need to open a discussion and if agreed apply it throughout the whole code base in one do.
I don't think that reverting black
for this case have any sense at this point as most of the bot's file was affected anyway.
But I agree that introducing black
should be centralized.
[...] as most of the bot's file was affected anyway.
But it has not. You may compare lines count changed in either case to see the difference.
@idlesign, I've removed all black-induced things. Pls review and consider merging. Then I may rebase take a look at #77 again
Seems fine, but without tests can't say for sure %) Let's try to merge. But mocked tests would be nice.
Thank you.
Self-explanatory
Fixes #74.
⚠️ additional testing advised
Also, I also used
black
to format Bot's source - I think we should use it all over the codebase to reduce the burden of keeping code style intact.