Added non-zero exit code to run_bots if there is no bots to actually run

idlesign / torrt

Automates torrent updates for you

https://github.com/idlesign/torrt

BSD 3-Clause "New" or "Revised" License

112 stars 19 forks source link

Closed NecroKote closed 2 years ago

NecroKote commented 2 years ago

Nice addition to #76

bot registration now raises BotRegistrationFailed if there are dependencies missing.
at launch, the user can see all the configured bots that failed to register as log warning
run_bots now exits with code 1 if were were no actual bots to run. this way systemd (or supervisord) status will show whether there is something wrong with bots on the start
~~renamed test_bots to test_bot_telegram and made it conditional on the required package. this helps to pass tests on build servers without installing additional dependencies.~~

(duplicate of #77, as for some reason it didn't pull latest commit)

coveralls commented 2 years ago

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
torrt/toolbox.py	12	13	92.31%
<!--	Total:	17	18	94.44%	-->

Files with Coverage Reduction	New Missed Lines	%
torrt/utils.py	1	87.21%
<!--	Total:	1		-->

NecroKote commented 2 years ago

@idlesign I think this one is done. Please review it again.

I've added a bunch of tests for new logic:

magic-mock for everything telegram-lib related
basic run_bots cycle (basically same test as before)
test_no_bots_to_run_exists checks that in deed, sys.exit(1) occurs on torrt run_bots without having a single configured bot
test_telegram_without_plugin_raises_exception basic check, that telegram behaves as we expect (raises BotRegistrationFailed)
test_bot_configured_but_unregistered checks that the user sees a new warning, about configured, but unregistered bot (for example - forgot to install plugin. this happens to me all the time)

PS: Python 3.6 failing because of dependency shift. I'll prepare basic 'housekeeping' PR - shifting dates to 2022, removing 3.6 support etc..

idlesign commented 2 years ago

Thank you. Merged.