search

idmillington / undum

A client-side framework for narrative hypertext interactive fiction.
https://idmillington.github.com/undum
MIT License
336 stars 80 forks source link

Added "data-exit" to HTML loader #21

Closed omigeot closed 10 years ago

omigeot commented 10 years ago

As simple as it sounds : allows to define an exit function from the HTML code.

idmillington commented 10 years ago

Can you say why you're doing this. It is never being called in the code. So as it stands it might be something better for your fork, for your projects, rather than in the main repo. But I'm happy to be corrected, if there's a use-case here that might be general.

omigeot commented 10 years ago

Well, I'm not sure it's the best way to do this, but I do try to keep all my situations in HTML form - I'd rather add some JavaScript to an HTML sit than define it completely in JS. So I do agree something more generic would be better (some way to declare a JS "constructor" to an HTML sit?), but that was off my league.

Ian Millington notifications@github.com a écrit :

Can you say why you're doing this. It is never being called in the code. So as it stands it might be something better for your fork, for your projects, rather than in the main repo. But I'm happy to be corrected, if there's a use-case here that might be general.

Reply to this email directly or view it on GitHub: https://github.com/idmillington/undum/pull/21#issuecomment-32841450

Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.

idmillington commented 10 years ago

I'm going to close this pull request, because as it stands it is seems quite specific to your project. But I'm happy to think of other alternatives.