idmillington / undum

A client-side framework for narrative hypertext interactive fiction.
https://idmillington.github.com/undum
MIT License
336 stars 80 forks source link

[bug] CSS bug in IE 11 #26

Closed Oreolek closed 10 years ago

Oreolek commented 10 years ago

Not my bug, but I've got a report: https://yadi.sk/i/a2Qh7PMSXFmEh All tutorials are affected, even the new one. IE 11 is hardly an old browser, so we have to fix it. Maybe recalculate tools_wrapper offsets?

Oreolek commented 10 years ago

UPD: fix by Nafanin #tools_wrapper { width: 100% } - didn't test it because I don't have IE 11 Also hr {margin: -1px auto -1px -2.8em} fixes delimiters.

idmillington commented 10 years ago

I don't have IE either! Hmm. That fix moves the panels out of the correct position in Webkit though. So I'd need to figure out how to bring them back correctly tweaking their margins etc. I can see the problem IE 11 isn't centering the tool wrapper. I'll have another look later. I thought IE 11 was pretty compliant with basic sizing and positioning, so I suspect it might be me, relying on something I shouldn't.

What was the problem about delimiters that needs fixing?

Nafanin commented 10 years ago

https://yadi.sk/i/rNqSzcVPXFwxu - margin: 100% works fine in Chrome and Opera 20.

idmillington commented 10 years ago

You have to see how it responds as you resize. When the width of the page is limited by the width of the browser, the spacing appears wrong for me (Chrome 36 on Mac 10.9).

http://imgur.com/K6NQVKE

On 24 July 2014 14:22, Nafanin notifications@github.com wrote:

https://yadi.sk/i/rNqSzcVPXFwxu - margin: 100% works fine in Chrome and Opera 20.

— Reply to this email directly or view it on GitHub https://github.com/idmillington/undum/issues/26#issuecomment-50015580.

Nafanin commented 10 years ago

Try this:

#tools_wrapper { width: 100%; left: 0; right: 0; }
.tools.left { left: 0.4em; }
.tools.right { right: 0.4em; }
idmillington commented 10 years ago

Perfect. Do you want to make the change and issue a push request, or should I make the change and commit?

Thanks for doing this.

Are you in the CREDITS file?

On 24 July 2014 14:37, Nafanin notifications@github.com wrote:

Try

tools_wrapper { width: 100%; left: 0; right: 0; }.tools.left { left: 0.4em; }.tools.right { right: 0.4em; }

— Reply to this email directly or view it on GitHub https://github.com/idmillington/undum/issues/26#issuecomment-50018263.

Nafanin commented 10 years ago

Please, make change and commit, I'm newbie in Github yet :) No, I'm not in the credits.

idmillington commented 10 years ago

I've corrected, committed and pushed this change (commit 831dd79). Thanks so much Nafanin.

I'd like to add you to the CREDITS file. The existing authors are listed by their offline names, but it doesn't have to be that way, let me know how you want me to credit you.

Nafanin commented 10 years ago

I've added my real name in my profile. Thank you.

idmillington commented 10 years ago

It is in the CREDITS file now, thanks.