search

idno / SoundCloud

SoundCloud plugin for Known
8 stars 7 forks source link

Fix Deprecation warnings #8

Closed lindner closed 3 years ago

lindner commented 4 years ago

Seeing messages in the logs. Also looks like this plugin hasn't been updated in a long long time.

Message is Use \\Idno\\Core\\Idno::site()->events()->addListener()

[Sun Feb 23 02:50:34.751856 2020] [php7:notice] [pid 11518] [client 10.88.0.1:54908] Known (1500wordmtu.com): debug - DEPRECATION WARNING: Use \\Idno\\Core\\Idno::site()->events()->addListener() [{"file":"/var/www/known/IdnoPlugins/SoundCloud/Main.php","line":40,"function":"addEventHook","class":"Idno\\\\Core\\\\Idno","type":"->","args":["user/auth/success",{}]},{"file":"/var/www/known/Idno/Common/Component.php","line":19,"function":"registerEventHooks","class":"IdnoPlugins\\\\Soundcloud\\\\Main","type":"->","args":[]},{"file":"/var/www/known/Idno/Core/Plugins.php","line":55,"function":"__construct","class":"Idno\\\\Common\\\\Component","type":"->","args":[]}]
[Sun Feb 23 02:50:34.751925 2020] [php7:notice] [pid 11518] [client 10.88.0.1:54908] Known (1500wordmtu.com): debug - DEPRECATION WARNING: Use \\Idno\\Core\\Idno::site()->events()->addListener() [{"file":"/var/www/known/IdnoPlugins/SoundCloud/Main.php","line":102,"function":"addEventHook","class":"Idno\\\\Core\\\\Idno","type":"->","args":["post/media/soundcloud",{}]},{"file":"/var/www/known/Idno/Common/Component.php","line":19,"function":"registerEventHooks","class":"IdnoPlugins\\\\Soundcloud\\\\Main","type":"->","args":[]},{"file":"/var/www/known/Idno/Core/Plugins.php","line":55,"function":"__construct","class":"Idno\\\\Common\\\\Component","type":"->","args":[]}]
[Sun Feb 23 02:50:34.751952 2020] [php7:notice] [pid 11518] [client 10.88.0.1:54908] Known (1500wordmtu.com): debug - DEPRECATION WARNING: Use \\Idno\\Core\\Idno::site()->routes()->addRoute() [{"file":"/var/www/known/IdnoPlugins/SoundCloud/Main.php","line":9,"function":"addPageHandler","class":"Idno\\\\Core\\\\Idno","type":"->","args":["soundcloud/deauth/?","\\\\IdnoPlugins\\\\SoundCloud\\\\Pages\\\\Deauth"]},{"file":"/var/www/known/Idno/Common/Component.php","line":20,"function":"registerPages","class":"IdnoPlugins\\\\Soundcloud\\\\Main","type":"->","args":[]},{"file":"/var/www/known/Idno/Core/Plugins.php","line":55,"function":"__construct","class":"Idno\\\\Common\\\\Component","type":"->","args":[]}]
[Sun Feb 23 02:50:34.752043 2020] [php7:notice] [pid 11518] [client 10.88.0.1:54908] Known (1500wordmtu.com): debug - DEPRECATION WARNING: Use \\Idno\\Core\\Idno::site()->routes()->addRoute() [{"file":"/var/www/known/IdnoPlugins/SoundCloud/Main.php","line":11,"function":"addPageHandler","class":"Idno\\\\Core\\\\Idno","type":"->","args":["soundcloud/callback/?","\\\\IdnoPlugins\\\\SoundCloud\\\\Pages\\\\Callback"]},{"file":"/var/www/known/Idno/Common/Component.php","line":20,"function":"registerPages","class":"IdnoPlugins\\\\Soundcloud\\\\Main","type":"->","args":[]},{"file":"/var/www/known/Idno/Core/Plugins.php","line":55,"function":"__construct","class":"Idno\\\\Common\\\\Component","type":"->","args":[]}]
[Sun Feb 23 02:50:34.752120 2020] [php7:notice] [pid 11518] [client 10.88.0.1:54908] Known (1500wordmtu.com): debug - DEPRECATION WARNING: Use \\Idno\\Core\\Idno::site()->routes()->addRoute() [{"file":"/var/www/known/IdnoPlugins/SoundCloud/Main.php","line":13,"function":"addPageHandler","class":"Idno\\\\Core\\\\Idno","type":"->","args":["admin/soundcloud/?","\\\\IdnoPlugins\\\\SoundCloud\\\\Pages\\\\Admin"]},{"file":"/var/www/known/Idno/Common/Component.php","line":20,"function":"registerPages","class":"IdnoPlugins\\\\Soundcloud\\\\Main","type":"->","args":[]},{"file":"/var/www/known/Idno/Core/Plugins.php","line":55,"function":"__construct","class":"Idno\\\\Common\\\\Component","type":"->","args":[]}]
[Sun Feb 23 02:50:34.752179 2020] [php7:notice] [pid 11518] [client 10.88.0.1:54908] Known (1500wordmtu.com): debug - DEPRECATION WARNING: Use \\Idno\\Core\\Idno::site()->routes()->addRoute() [{"file":"/var/www/known/IdnoPlugins/SoundCloud/Main.php","line":15,"function":"addPageHandler","class":"Idno\\\\Core\\\\Idno","type":"->","args":["account/soundcloud/?","\\\\IdnoPlugins\\\\SoundCloud\\\\Pages\\\\Account"]},{"file":"/var/www/known/Idno/Common/Component.php","line":20,"function":"registerPages","class":"IdnoPlugins\\\\Soundcloud\\\\Main","type":"->","args":[]},{"file":"/var/www/known/Idno/Core/Plugins.php","line":55,"function":"__construct","class":"Idno\\\\Common\\\\Component","type":"->","args":[]}]
mapkyca commented 4 years ago

Soundcloud hasn't been touched for a long time... tbh I wasn't aware that people really used it, and I was considering deprecating the module.

I'll try and find time to look at it if people do still find it useful

lindner commented 3 years ago

Fixed in https://github.com/idno/SoundCloud/pull/9