idno / indiepub

Support IndieAuth and Micropub for Known sites.
8 stars 9 forks source link

[Micropub] Editing a post in Known can have destructive side effects on content #11

Open cleverdevil opened 6 years ago

cleverdevil commented 6 years ago

There is a bug in Known which causes HTML posts published via Micropub to be changed (usually in bad ways) when "editing" the post, even when you don't actually make any changes to the post. I discovered this issue when publishing via Sunlit 2.0, which supports Micropub.

I published two stories:

Because Sunlit doesn't yet support syndication via Micropub, I clicked "edit" on one of the posts, and toggled on syndication to Twitter and Facebook, and then clicked "save." The result was that the post's content was changed (in a destructive way, resulting in visual regressions), even though I hadn't actually edited the content, or even clicked into the content editor.

Seems like this is a bug.

(Originally published at: https://cleverdevil.io/2018/editing-a-post-in-known-can-have-destructive-side-effects)

cleverdevil commented 6 years ago

Did some investigation, and it appears that the editor is basically stripping out (some? all?) inline styles.

mapkyca commented 6 years ago

Is this still a thing? I seem to remember doing something in this domain a little while ago...