idno / known

A social publishing platform.
https://withknown.com/opensource
Other
1.06k stars 194 forks source link

Hashtags not workin #890

Closed tsparks closed 9 years ago

tsparks commented 9 years ago

I upgraded my self hosted site to 7.1.1 from 6.3 and ever sense the #hashtags no longer return content; the hashtag shows on the post as a link but I click it , it doesn't return any linked posts.

My site: http://tom.sparkshouse.com

Any advice would appreciated.... Thanks

kylewm commented 9 years ago

note: we noticed when looking at this problem in IRC that the old style content/all?q=#hashtag links still work, but the new /tag/hashtag links are empty.

kylewm commented 9 years ago

@tsparks have you tried upgrading to the latest version (0.7.8)?

0.7.1 is several months old at this point, and it's very possible this problem was already fixed.

tsparks commented 9 years ago

I will try that

tsparks commented 9 years ago

I upgraded my version to 7.8, and the hashtag issue still exisits. During the upgrade I think I found a useful clue, my site is not setup in the standard default way. All the uploaded files (.jpg's) are in a folder called data. The config file points there

uploadpath = "/usr/home/tomsparks/public_html/tom/data/"

I believe it is suppose to point to Uploads. Can I rewrite the conf file to point to Uploads and move the content from data to uploads? I am not sure if the program will break if I do that.

kylewm commented 9 years ago

Hmm, I'd be surprised if this particular issue was affected by the Uploads folder.

Could you provide some details of your setup. Are you using MySQL or MongoDB? Apache or nginx? What hosting provider? Is there anything interesting in the server logs right after you try to hit a tag URL like http://tom.sparkshouse.com/tag/photography?

tsparks commented 9 years ago

Site is hosted by Pair.net FreeBSD MySQL Appche PHP 5.3.5.

I don't think I have access to server logs I will look into that, I run this out of a sub directory as a sub domain as you see by the URL

kylewm commented 9 years ago

PHP 5.3.5.

That might be the problem right there. Known requires 5.4 or above (https://github.com/idno/Known/blob/master/docs/install/requirements.md)

davidmead commented 9 years ago

One thing that could be a related issue is my hashtags, coming in from Instagram, are breaking if the start with a number

screen shot 2015-05-12 at 2 55 08 pm See this post at http://blog.davidjohnmead.com/2015/coffee.

Only started happening recently. I thought I'd inadvertently put a space between the two, but when I edit the Known post I still get the same thing.

kylewm commented 9 years ago

@davidmead that looks like a separate issue, since http://blog.davidjohnmead.com/tag/365daysofme and http://blog.davidjohnmead.com/tag/x6 still work for your site even though hashtags containing numbers are not auto-linked properly. If want to file an issue, refer to this line of the code https://github.com/idno/Known/blob/0e865a83ae9c144344402d0050a9b47ed5598bb1/Idno/Core/Template.php#L271

In particular the regex matches \p{L} which is letters only, no numbers.

benwerd commented 9 years ago

We're going to push a fix for this imminently. The regex is indeed broken.

tsparks commented 9 years ago

I was mistaken I have php54.cgi running in my web folder

I recreated my site using a fresh install of Known 7.8, I kept three things, the htaccess file, the config.ini and the data folder.

One of those three things is the problem. I never changed the config,ini settings so it has to be the folder I upload to or the htaccess file. I think it is the data folder.

benwerd commented 9 years ago

Various fixes for hashtags have now been committed.

benwerd commented 9 years ago

Confirming that an upgrade will fix the problem. A new installer will be rolled out on Saturday morning PDT.