search

ido50 / Locale-Wolowitz

Dead simple localization for web apps with JSON.
http://search.cpan.org/dist/Locale-Wolowitz
10 stars 5 forks source link

Please do not undef $/ globally. #3

Closed kberov closed 10 years ago

kberov commented 10 years ago

Hello Ido, You globally undefined $/ which is dangerous for people using your code. https://github.com/ido50/Locale-Wolowitz/blob/65b303828df7406bd4858227986e13466a415df9/lib/Locale/Wolowitz.pm#L228

Please fix according to recomendations and example given here: http://perldoc.perl.org/perlvar.html#Variables-related-to-filehandles You can be warned automatically if you just add Test::Perl::Critic tests. Here is an example: https://github.com/kberov/Ado/blob/master/t/perl-critic.t I hope you take it positively. Regards, Krasi Berov Otherwise I like the simplified approach to L10N.

ido50 commented 10 years ago

You learn something new every day. Fixed and released new version to CPAN. Thanks for reporting and providing information.