search

ido50 / morgan

PyPI Mirror for Restricted/Offline Environments
Apache License 2.0
105 stars 7 forks source link

feat: morgan.ini: +multiline values #16

Closed shamilbi closed 5 months ago

shamilbi commented 1 year ago

closes #15

alex-orange commented 9 months ago

I'd like to note this that also fixes a problem I just ran into. I was having trouble with pyyaml not being able to build because Cython<3.0 hadn't been pulled in. Turns out it's because morgan's just seeing that "Cython" has already been processed, without paying attention to the requirement. A previous package had some other requirement for Cython which was fulfilled by 3.0.8, which clearly isn't fulfilled by <3.0, but checking the name instead of the full requirement missed it.

This also fixes my issue #17 another similar but slightly different issue.

ido50 commented 9 months ago

That's great, I knew from the beginning that the _processed_pkgs map would not be sufficient. I think with these changes there'll still be recursion if two different requirement strings resolve to the same version. I'll run some tests tomorrow and try to get this in ASAP. Don't know how I missed this PR before, sorry for that.