search

ido50 / morgan

PyPI Mirror for Restricted/Offline Environments
Apache License 2.0
105 stars 7 forks source link

Fix supported platforms regex #2

Closed i077 closed 2 years ago

i077 commented 2 years ago

This was preventing (many)linux wheels from downloading (and probably other wheels?), since there was an unintentional leading r in the regex.

ido50 commented 2 years ago

Great catch! Thanks a lot for fixing this bug. That regex was kinda iffy to begin with and I'm not even sure it would work correctly for windows environments, but the whole "manylinux" "musllinux" is a bit of a mess as well, since libc versions are not part of the environment marker specification. I hope to improve this part of the code soon. Anyway, thanks a lot for the contribution.

ido50 commented 2 years ago

Published this as v0.12.1