idoenk / dev-kaskus-quick-reply

Automatically exported from code.google.com/p/dev-kaskus-quick-reply
2 stars 0 forks source link

JavaScript namespace pollution and innerHTML should not be set dynamically #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
contains a large number of global variables, which can conflict with other 
add-ons. For more information, see 
http://blog.mozilla.com/addons/2009/01/16/firefox-extensions-global-namespace-po
llution/, or use JavaScript modules.

Warning: List of entities: el, isAboveNow, GM_getValue, wascypos, rL, 
unsafeWindow, ss_stepsize, opt_val, GM_log, ccid, par, img, cL, 
GM_registerMenuCommand, ret, GM_xmlhttpRequest, re, GM_isAddon, cypos, imgEl2, 
ck_mquote, Attr, GM_setValue, nid, imgEl, realcont, GM_getIntValue, 
GM_openInTab, imgtxta, obj, ids, value, iscypos, el2, isAbove, GM_deleteValue

and 
Due to both security and performance reasons, innerHTML should not be set using 
dynamic values. This can lead to security issues or fairly serious performance 
degradation.

look at attach a file

Original issue reported on code.google.com by Pil...@gmail.com on 30 Jul 2011 at 4:05

Attachments:

GoogleCodeExporter commented 9 years ago
thx for the report, but ergh, there are 141 match of innerHTML,. do'oh ..
can't transform it soon, maybe later. :p

workin on global var now..

Original comment by 1d0...@gmail.com on 31 Jul 2011 at 7:36

GoogleCodeExporter commented 9 years ago
tetap menunggu buat innerHTML-nya  hehehe :P :D

Original comment by Pil...@gmail.com on 15 Aug 2011 at 8:33

GoogleCodeExporter commented 9 years ago
Cleanup; issue overdue and mostly invalid with the new codebase.
Please create a new issue if issue persisted.

Original comment by Sanjito....@gmail.com on 3 Feb 2015 at 9:46