search

idoenk / dev-kaskus-quick-reply

Automatically exported from code.google.com/p/dev-kaskus-quick-reply
2 stars 0 forks source link

Fixups detection error #56

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Fixups detection is not working as intended. Please refer to the following 
screenshot:
http://puu.sh/a9ClI/4efb0bef27.png

`window.getComputedStyle(document.body).getPropertyValue('content')` returns 
additional quote inside the string element.

The code can be found here:
https://code.google.com/p/dev-kaskus-quick-reply/source/browse/trunk/kaskus_quic
k_reply.user.dev.js?spec=svn490&r=490#6401

Adding quotes manually around gvar.kfs4 should fix the issue; like so:
gvar.is_kfs4 = 
(window.getComputedStyle(document.body).getPropertyValue('content') === '"' + 
gvar.KSF4 + '"');

Original issue reported on code.google.com by Sanjito....@gmail.com on 13 Jul 2014 at 4:36

GoogleCodeExporter commented 9 years ago 
I think i'd rather use regex to detect it.
patched r491, Thx.

Original comment by 1d0...@gmail.com on 13 Jul 2014 at 10:29

GoogleCodeExporter commented 9 years ago 
Fix verified to work.

P.S: It's "s4", not "S4"!

Original comment by Sanjito....@gmail.com on 13 Jul 2014 at 10:37