idoerg / cafa-format-check

Format checkers for CAFA predictions files
GNU General Public License v3.0
6 stars 6 forks source link

Cafa4 pull request #6

Closed szarecor closed 4 years ago

szarecor commented 4 years ago

I believe this code is ready to go.

The original zip files and some other files that are not being used have been moved to the BAK directory to unclutter the root.

Most of those zip files are represented in some form in the test data within the /test/ directory.

As previously discussed, I targeted python 2 with this, I used 2.7

That being said, only 1 of the 35 tests fails with Python3.8. I'm going to investigate that early next week, because i'm curious/concerned as to why that fails with Python 3.

$ python3.8 -m pytest test/test_cafa4_checker.py::test_go_and_do_zip_file -vs
=============================================================================================== test session starts ===============================================================================================
platform linux -- Python 3.8.1, pytest-5.3.2, py-1.8.1, pluggy-0.13.1 -- /usr/bin/python3.8
cachedir: .pytest_cache
rootdir: /home/szarecor/venvs/cafa-format-check/code/cafa-format-check
collected 1 item                                                                                                                                                                                                  

test/test_cafa4_checker.py::test_go_and_do_zip_file 

OUTPUT:
TESTING /home/szarecor/venvs/cafa-format-check/code/cafa-format-check/test/test_data/end_to_end_data/valid/ateam_.zip

VALIDATION FAILED
Error in TC_ateam_1_9606_go.txt, line 1, GO prediction: wrong number of fields. Should be 3

FAILED

Tests can be run with pytest, (which can be installed with pip).

From the repo root run: python -m pytest

Let my know if you have questions, concerns, etc.