Addressed PR comments. - Githubissues

idontgetoutmuch / random

Random number library

Other

3 stars 2 forks source link

Addressed PR comments. #160

Closed lehins closed 4 years ago

lehins commented 4 years ago

Switched to newer unreleased smallcheck-1.2
Removed cabal.project
Adjust .gitignore
Add some comments on bitmask with rejection

@Bodigrim Here are some of your comments addressed. Thank you for suggestion about quotRem -> quot + rem, performance did improve slightly and I learned something new ;)

When do you expect to release smallcheck-1.2?

curiousleo commented 4 years ago

When do you expect to release smallcheck-1.2?

It's already done: https://hackage.haskell.org/package/smallcheck-1.2.0

Bodigrim commented 4 years ago

LGTM, but shouldn't it be targeted to v1.2-squashed-proposal to appear in https://github.com/haskell/random/pull/62 once merged?

lehins commented 4 years ago

@Bodigrim I've just been updating v1.2-squashed-proposal manually, so no problem on this.